Comments on Improved edit mode

Last modified by Ecaterina Moraru on 2018/09/26 16:02

  • Marta Girdea
    Marta Girdea, 2010/01/22 11:29

    JV, in the wiki edit mode, I'd put Parent before Language. Also, we should keep the link to syntax help, for example by putting something like Failed to execute the [velocity] macro. Cause: [The execution of the [velocity] script macro is not allowed in [incubator:Improvements.ImprovedEdit]. Check the rights of its last author or the parameters if it's rendered from another script.]. Click on this message for details.
    next to the Syntax label (don't know if it's the best place).

  • Sergiu Dumitriu
    Sergiu Dumitriu, 2010/01/22 11:48

    I don't like the edit fields placed on the top of the content:
    - there are too many
    - they are not related, since they are about completely different things (content syntax, localization, user-friendly title, hierarchy)
    - the language really doesn't work as a select box, since changing it should reload the document in that language
    - the parent should be next to the title
    - the parent should be a bit larger

    The most important and tangible criticism is about the language, which IMO should be moved in the edit menu, as links.

    This leaves the syntax, which is closely related to the content, and is a bit technical (basic users will be confused by it). I'd go as far as hiding it for non-advanced users.

  • Ecaterina Valica
    Ecaterina Valica, 2010/01/22 15:52

    propC1.png

    • Ecaterina Valica
      Ecaterina Valica, 2010/01/22 15:55

      Language is in the menu - suggesting that page needs refresh. All languages will be in the menu, but will be shown active just the versions that exists for this page.

      Parent fields need auto-suggest.

      Content integrates included documents. To see how it looks when there are multiples documents included see this

      • Sergiu Dumitriu
        Sergiu Dumitriu, 2010/01/22 16:09

        Looks good, except that I'd make the parent input smaller (75/25 or 66/33).

        I'd say:
        CONTENT (Includes: Blog.BlogParameters[/], Blog.BlogCode[/])

        Still, in the WYSIWYG editor, does the "Help on the syntax" make any sense? Yes, if we consider the Source tab.

        • Anca Luca
          Anca Luca, 2010/01/23 20:42

          The source tab shouldn't be there, transforms the Wysiwyg editor in a wiki editor and makes things sort of inconsistent. For example, 

          • we cannot remove this help on wiki syntax, although it's completely irrelevant for users seeing the wysiwyg editor (I think pretty few of them move to Source)
          • we cannot remove the syntax selector all together, which doesn't make sense at all in a wysiwyg editor (actually, the syntax selector would be useful for the source tab which disappears anyway when you change syntax, it's doesn't make too much sense),
          • it doesn't look good together with the Content label (having Content, Wysiwyg, Source), all there looks bad.
          • and, last but definitely not least, we already have the wiki editor to edit wiki, that's just duplicated functionality, we should set for only one of them and my vote goes for wiki editor
          • oh, and also it's not displayed when editing wysiwyg an inline form (blog for example).

          WDYT?

          • Marta Girdea
            Marta Girdea, 2010/01/24 23:06

            Re "The source tab shouldn't be there, transforms the Wysiwyg editor in a wiki editor and makes things sort of inconsistent": BIG +1, the tabs on top of the wysiwyg really shouldn't be there. 

      • Marta Girdea
        Marta Girdea, 2010/01/22 16:19

        That looks great.

        Three minor comments:

        • I'd make the title field larger than the parent field, because you usually need to write more in the title field. Of course, then they might look a bit unbalanced, so if this turns out to be an issue they can be left with equal sizes. 
        • Re "All languages will be in the menu, but will be shown active just the versions that exists for this page" - indeed there must be a difference between the appearance of entries for existing translations and non-existing translation, but I wouldn't say non-existing translation should look/be inactive, because the user should be able to create a new translation, and be aware of this possibility.
        • I'm not sure about listing the included documents before the text area, but I can't come up with a much better place either. One option is to list them under the text area, because they are not that important. However, this position would really decrease their visibility.
        • Ecaterina Valica
          Ecaterina Valica, 2010/01/22 16:45

          I've put the included documents before the text for cases like Blog.BlogCode, when you have pages that contain just included doc and you don't need to scroll to be able to access them.

  • Ecaterina Valica
    Ecaterina Valica, 2010/01/22 16:22

    After some complains about Included Documents and Comment describing text:
    propD1.png

    • Marta Girdea
      Marta Girdea, 2010/01/22 16:23

      How about the complaints about the parent field size? emoticon_smile

    • Ecaterina Valica
      Ecaterina Valica, 2010/01/22 16:23

      This prop changes the way last three options are displayed. I prefer propC.

      Included documents have their specific place. Are we sure we want to remove all the panels? Included documents and localization could be better explained in a panel.

  • Ecaterina Valica
    Ecaterina Valica, 2010/01/22 16:43

    propE1.png

    • Marta Girdea
      Marta Girdea, 2010/01/22 16:50

      For included documents: the brackets should either be around "Includes" as well, or should disappear completely. Otherwise, this looks great.

    • Marta Girdea
      Marta Girdea, 2010/01/22 16:54

      Just a thought: would the "autosave" part go better on the same line with the form buttons? IMO, semantically, it is more related to the buttons than to the change comment.

      • Ecaterina Valica
        Ecaterina Valica, 2010/01/22 17:11

        I didn't test autosave, but every 5 minutes the page saves with the comment described and as minor change if selected?

        • Ecaterina Valica
          Ecaterina Valica, 2010/01/22 17:24

          so autosave acts like a minor change with the current comment - the position is ok if we thing autosave apply those fields.

          Being on the line with buttons would describe the save action better. Would fit so well though. 

  • Marta Girdea
    Marta Girdea, 2010/01/22 21:03

    I just realized the tags are missing from all the proposals. Was that on purpose? If not, would it be OK to put them under the content?

    • Ecaterina Valica
      Ecaterina Valica, 2010/01/23 01:02

      If we put them under the content we really need the separator helping text "Comma separated tags" and this separator shouldn't change to "|" when editing back the page.

      Are we sure we want tags in the edit mode? We already have a interface for them in the view.